Date: Tue, 26 Jan 2010 12:16:41 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Dongdong Deng <libfetion@gmail.com>
cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
       Jason Wessel <jason.wessel@windriver.com>, linux-kernel@vger.kernel.org,
       kgdb-bugreport@lists.sourceforge.net, mingo@elte.hu,
       John Stultz <johnstul@us.ibm.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Magnus Damm <damm@igel.co.jp>
Subject: Re: [PATCH 3/4] kgdb,clocksource: Prevent kernel hang in kernel
 debugger
In-Reply-To: <alpine.LFD.2.00.1001261108410.5926@localhost.localdomain>
Message-ID: <alpine.LFD.2.00.1001261204100.5926@localhost.localdomain>
References: <1264480000-6997-1-git-send-email-jason.wessel@windriver.com>  <1264480000-6997-4-git-send-email-jason.wessel@windriver.com>  <20100126092234.77b363d4@mschwide.boeblingen.de.ibm.com>  <alpine.LFD.2.00.1001260946530.5926@localhost.localdomain>
 <ce2c83091001260201j62a770d2r2379a9293f909d87@mail.gmail.com> <alpine.LFD.2.00.1001261108410.5926@localhost.localdomain>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1166
Lines: 30

On Tue, 26 Jan 2010, Thomas Gleixner wrote:
> There is no sane way to reliably prevent TSC from becoming unstable
> when kgdb stops the kernel inside the watchdog code. And I do not care
> about that at all.
> 
> I'm not going to clutter code with crazy workarounds just because some
> people believe that using a kernel debugger is a good idea. If people
> insist on using kgdb then the possible "TSC becomes unstable" side
> effect is the least of their problems.

Btw, if the kernel uses tick based timekeeping or a clock source which
wraps in rather short intervals (e.g. pm-timer wraps after ~4.6
seconds), stopping the kernel with kgdb will inevitably screw up time
keeping anyway.

So there is really no reason to worry about TSC becoming unstable.

There is only one real sensible solution for this:

 Do _not_ use kgdb - which is the modus operandi of every sane kernel
 developer on the planet.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/