DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=BmkLSVormpiNwbdim5IIuBNhRuBYfLRugaXEMwhxZ9YyUihhcdoJ/65O2iuWsKsjBK
         Vudjv7T8y0fhnHFDGUTCw0S9rs3SXExig4yxZ7rluSjMmQ3wWpvKAh+KeAuMwZX9Gtyg
         pYNawETV6Un/oxJFNvMKiBbMDQ7RhWHDITZ0w=
MIME-Version: 1.0
In-Reply-To: <1264503701.3067.69.camel@odin>
References: <771cded01001120041ue24edabk8e4638ef7151c947@mail.gmail.com>
	 <771cded01001120051l44fd76bx80d2fd4b6f60bd0b@mail.gmail.com>
	 <20100112115156.GA546@rakim.wolfsonmicro.main>
	 <771cded01001250301q465a9f8ma484f597ae9a292f@mail.gmail.com>
	 <20100125135628.GB26613@rakim.wolfsonmicro.main>
	 <771cded01001252226k342723b3p3ea235fe79c46843@mail.gmail.com>
	 <1264503701.3067.69.camel@odin>
Date: Tue, 26 Jan 2010 06:51:59 -0500
Message-ID: <771cded01001260351w21af1448q9439fad3821c3c55@mail.gmail.com>
Subject: Re: [PATCH 01/01] regulator: support max8649
From: Haojian Zhuang <haojian.zhuang@gmail.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
       linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
       linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1236
Lines: 33

On Tue, Jan 26, 2010 at 6:01 AM, Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> On Tue, 2010-01-26 at 01:26 -0500, Haojian Zhuang wrote:
>> From 2b5a73c336d2b5dc48c8cf1f2a804b6968659f78 Mon Sep 17 00:00:00 2001
>> From: Haojian Zhuang <haojian.zhuang@marvell.com>
>> Date: Mon, 25 Jan 2010 10:24:09 -0500
>> Subject: [PATCH] regulator: enable max8649 regulator driver
>>
>> Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
>
> Can you confirm all the changes compared to the last version.
>
Yes, exactly.

>> +static int max8649_get_voltage(struct regulator_dev *rdev)
>> +{
>> + ? ? ? struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
>> + ? ? ? unsigned char data;
>> + ? ? ? int ret;
>> +
>> + ? ? ? ret = max8649_reg_read(info->i2c, info->vol_reg);
>> + ? ? ? if (ret < 0)
>> + ? ? ? ? ? ? ? return ret;
>> + ? ? ? data = (unsigned char)ret & MAX8649_VOL_MASK;
>> + ? ? ? return (max8649_list_voltage(rdev, data));
>
> Any reason why we have extra () here ?
>
Fixed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/