Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753040Ab0AZMBB (ORCPT ); Tue, 26 Jan 2010 07:01:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752787Ab0AZMBA (ORCPT ); Tue, 26 Jan 2010 07:01:00 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:53332 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752577Ab0AZMBA (ORCPT ); Tue, 26 Jan 2010 07:01:00 -0500 Date: Tue, 26 Jan 2010 12:00:58 +0000 From: Mark Brown To: Haojian Zhuang Cc: Liam Girdwood , linux-arm-kernel , linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/01] regulator: support max8649 Message-ID: <20100126120058.GN15759@rakim.wolfsonmicro.main> References: <771cded01001120041ue24edabk8e4638ef7151c947@mail.gmail.com> <771cded01001120051l44fd76bx80d2fd4b6f60bd0b@mail.gmail.com> <20100112115156.GA546@rakim.wolfsonmicro.main> <771cded01001250301q465a9f8ma484f597ae9a292f@mail.gmail.com> <20100125135628.GB26613@rakim.wolfsonmicro.main> <771cded01001252226k342723b3p3ea235fe79c46843@mail.gmail.com> <20100126110420.GI15759@rakim.wolfsonmicro.main> <771cded01001260354y7c7db25bqa8bbfe000e0c0380@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <771cded01001260354y7c7db25bqa8bbfe000e0c0380@mail.gmail.com> X-Cookie: I'm ANN LANDERS!! I can SHOPLIFT!! User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 17 On Tue, Jan 26, 2010 at 06:54:48AM -0500, Haojian Zhuang wrote: > On Tue, Jan 26, 2010 at 6:04 AM, Mark Brown > > I'd expect the time taken to enable to be the voltage multipled by the > > step size rather than divided by the step size? > I don't agree at this point. The unit of step is uV/uSec. The function > should return uSec. So voltage divided by the step is more reasonable. Ah, then the variable step is confusingly named since it's actually a rate of change rather than a step size - I'd suggest rate or something like that instead. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/