Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754106Ab0AZUCt (ORCPT ); Tue, 26 Jan 2010 15:02:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753888Ab0AZUCs (ORCPT ); Tue, 26 Jan 2010 15:02:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14892 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753803Ab0AZUCr (ORCPT ); Tue, 26 Jan 2010 15:02:47 -0500 Date: Tue, 26 Jan 2010 15:02:10 -0500 From: Valerie Aurora To: Erez Zadok Cc: Jan Blunck , Alexander Viro , Christoph Hellwig , Andy Whitcroft , Scott James Remnant , Sandu Popa Marius , Jan Rekorajski , "J. R. Okajima" , Arnd Bergmann , Vladimir Dronnikov , Felix Fietkau , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Blunck Subject: Re: [PATCH 17/41] whiteout: Add path_whiteout() helper Message-ID: <20100126200210.GA10855@shell> References: <1256152779-10054-18-git-send-email-vaurora@redhat.com> <200911300757.nAU7vU73022810@agora.fsl.cs.sunysb.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200911300757.nAU7vU73022810@agora.fsl.cs.sunysb.edu> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1967 Lines: 52 On Mon, Nov 30, 2009 at 02:57:30AM -0500, Erez Zadok wrote: > In message <1256152779-10054-18-git-send-email-vaurora@redhat.com>, Valerie Aurora writes: > > From: Jan Blunck > > > > Add a path_whiteout() helper for vfs_whiteout(). > > > > Signed-off-by: Jan Blunck > > Signed-off-by: Valerie Aurora > > --- > > fs/namei.c | 15 ++++++++++++++- > > include/linux/fs.h | 1 - > > 2 files changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/fs/namei.c b/fs/namei.c > > index 9a62c75..408380d 100644 > > --- a/fs/namei.c > > +++ b/fs/namei.c > > @@ -2231,7 +2231,7 @@ static inline int may_whiteout(struct inode *dir, struct dentry *victim, > > * After this returns with success, don't make any assumptions about the inode. > > * Just dput() it dentry. > > */ > > -int vfs_whiteout(struct inode *dir, struct dentry *dentry, int isdir) > > +static int vfs_whiteout(struct inode *dir, struct dentry *dentry, int isdir) > > Didn't some other patch introduce vfs_whiteout? So why have a second patch > which makes vfs_whiteout a static? Why not introduce both vfs_whiteout and > path_whiteout in one patch? You're right, I merged those patches. > > { > > int err; > > struct inode *old_inode = dentry->d_inode; > > @@ -2283,6 +2283,19 @@ int vfs_whiteout(struct inode *dir, struct dentry *dentry, int isdir) > > return err; > > } > > > > +int path_whiteout(struct path *dir_path, struct dentry *dentry, int isdir) > > Please document the behavior of path_whiteout in a proper comment above ii > (kernel-doc). Describe return values, side effects, etc. Superseded by improved vfs_whiteout() documentation. Thanks, -VAL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/