DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=alczl/u9rIWSK7TepgvlLGXsp6qlVk5UoY2mdji0jD5JT+58ZK18CTF6EYrSDx7aZHidFJ6ZrRZ22tjgDuMNMINLu1KD2t925AxEVhyCAatyaPPDTg8qJ2JAY/YFjISu56ZzcBXdr0F8GqaYJpW067mcuIXUBb5YnWP1PrxbEaE=  ;
From: David Brownell <david-b@pacbell.net>
To: avorontsov@ru.mvista.com
Subject: Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier
Date: Tue, 26 Jan 2010 13:01:05 -0800
User-Agent: KMail/1.9.10
Cc: Grant Likely <grant.likely@secretlab.ca>,
       David Brownell <dbrownell@users.sourceforge.net>,
       Andrew Morton <akpm@linux-foundation.org>,
       Bill Gatliff <bgat@billgatliff.com>,
       "Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
       Benjamin Herrenschmidt <benh@kernel.crashing.org>,
       linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
References: <20100125180957.GA5380@oksana.dev.rtsoft.ru> <201001252234.30169.david-b@pacbell.net> <20100126172824.GA20319@oksana.dev.rtsoft.ru>
In-Reply-To: <20100126172824.GA20319@oksana.dev.rtsoft.ru>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <201001261301.05475.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 709
Lines: 18

On Tuesday 26 January 2010, Anton Vorontsov wrote:
> > Just
> > inline the little two blocking_notifier_call_chain() calls directly,
> > making this a *LOT* simpler.
> 
> I'd rather stay with gpio_call_chain() helper, it makes the code
> a little bit prettier, IMO. Compare this:

The one without the wrapper is IMO more clear, since it doesn't
obfuscate anything.  Fewer lines of code, too.  :)

Pretty is a good attribute ... but is a distant third to clarity.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/