Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753613Ab0A0NJZ (ORCPT ); Wed, 27 Jan 2010 08:09:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752658Ab0A0NJY (ORCPT ); Wed, 27 Jan 2010 08:09:24 -0500 Received: from www84.your-server.de ([213.133.104.84]:46843 "EHLO www84.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893Ab0A0NJY (ORCPT ); Wed, 27 Jan 2010 08:09:24 -0500 Subject: [PATCH] checkpatch.pl: remove the 80 charactes punch card limit From: Stefani Seibold To: linux-kernel Cc: Andrew Morton , apw@canonical.com, jschopp@austin.ibm.com, davej@redhat.com Content-Type: text/plain; charset="ISO-8859-15" Date: Wed, 27 Jan 2010 14:09:07 +0100 Message-ID: <1264597747.3607.29.camel@wall-e> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: 7bit X-Authenticated-Sender: stefani@seibold.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 38 The time of 80 characters punch card and terminals are over, so i would be a good thing to set the line length limit to 120. Every display today should be able handle this. Signed-off-by: Stefani Seibold --- checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-2.6.33-rc2.orig/scripts/checkpatch.pl 2009-12-03 04:51:21.000000000 +0100 +++ linux-2.6.33-rc2.new/scripts/checkpatch.pl 2010-01-06 17:46:40.057565661 +0100 @@ -1374,13 +1374,13 @@ sub process { # check we are in a valid source file if not then ignore this hunk next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/); -#80 column limit +#120 column limit if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ && $rawline !~ /^.\s*\*\s*\@$Ident\s/ && $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ && - $length > 80) + $length > 120) { - WARN("line over 80 characters\n" . $herecurr); + WARN("line over 120 characters\n" . $herecurr); } # check for adding lines without a newline. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/