Message-ID: <4B60BE31.5030707@windriver.com>
Date: Wed, 27 Jan 2010 16:29:05 -0600
From: Jason Wessel <jason.wessel@windriver.com>
User-Agent: Thunderbird 2.0.0.23 (X11/20090817)
MIME-Version: 1.0
To: Frederic Weisbecker <fweisbec@gmail.com>
CC: linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net,
       mingo@elte.hu, "K.Prasad" <prasad@linux.vnet.ibm.com>,
       Peter Zijlstra <peterz@infradead.org>,
       Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 2/4] perf,hw_breakpoint: add lockless reservation forhw_breaks
References: <1264480000-6997-1-git-send-email-jason.wessel@windriver.com> <1264480000-6997-3-git-send-email-jason.wessel@windriver.com> <4B5F419F.2090901@windriver.com> <20100127175647.GA23017@nowhere>
In-Reply-To: <20100127175647.GA23017@nowhere>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 816
Lines: 32

Frederic Weisbecker wrote:
> On Tue, Jan 26, 2010 at 01:25:19PM -0600, Jason Wessel wrote:
>   
>> @@ -250,11 +326,16 @@ int reserve_bp_slot(struct perf_event *b
>>  
>>  	mutex_lock(&nr_bp_mutex);
>>  
>> +	ret = dbg_hw_breakpoint_alloc(bp->cpu);
>> +	if (ret)
>> +		goto end;
>> +
>>     
>
>
>
> This is totally breaking all the constraints that try to
> make the reservation cpu-wide/task-wide aware.
>   

Agreed.  I was unaware of all the various pieces that the toggle_bp
handled.

A revised series is on the way based on the off-list discussion.

Thanks,
Jason.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/