Date: Thu, 28 Jan 2010 13:28:12 +1100
From: Neil Brown <neilb@suse.de>
To: Milan Broz <mbroz@redhat.com>
Cc: Marti Raudsepp <marti@juffo.org>,
       "Ing. Daniel =?UTF-8?B?Um96c255w7M=?=" <daniel@rozsnyo.com>,
       linux-kernel@vger.kernel.org
Subject: Re: bio too big - in nested raid setup
Message-ID: <20100128132812.2d01f211@notabene>
In-Reply-To: <4B5DE2A9.4030500@redhat.com>
References: <4B5C963D.8040802@rozsnyo.com>
	<5ec358371001250725l40b13060md880001c96be165f@mail.gmail.com>
	<4B5DE2A9.4030500@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1949
Lines: 49

On Mon, 25 Jan 2010 19:27:53 +0100
Milan Broz <mbroz@redhat.com> wrote:

> On 01/25/2010 04:25 PM, Marti Raudsepp wrote:
> > 2010/1/24 "Ing. Daniel Rozsnyó" <daniel@rozsnyo.com>:
> >> Hello,
> >>  I am having troubles with nested RAID - when one array is added to the
> >> other, the "bio too big device md0" messages are appearing:
> >>
> >> bio too big device md0 (144 > 8)
> >> bio too big device md0 (248 > 8)
> >> bio too big device md0 (32 > 8)
> > 
> > I *think* this is the same bug that I hit years ago when mixing
> > different disks and 'pvmove'
> > 
> > It's a design flaw in the DM/MD frameworks; see comment #3 from Milan Broz:
> > http://bugzilla.kernel.org/show_bug.cgi?id=9401#c3
> 
> Hm. I don't think it is the same problem, you are only adding device to md array...
> (adding cc: Neil, this seems to me like MD bug).
> 
> (original report for reference is here http://lkml.org/lkml/2010/1/24/60 )

No, I think it is the same problem.

When you have a stack of devices, the top level client needs to know the
maximum restrictions imposed by lower level devices to ensure it doesn't
violate them.
However there is no mechanism for a device to report that its restrictions
have changed.
So when md0 gains a linear leg and so needs to reduce the max size for
requests, there is no way to tell DM, so DM doesn't know.  And as the
filesystem only asks DM for restrictions, it never finds out about the
new restrictions.

This should be fixed by having the filesystem not care about restrictions,
and the lower levels just split requests as needed, but that just hasn't
happened....

If you completely assemble md0 before activating the LVM stuff on top of it,
this should work.

NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/