Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754992Ab0A1HY3 (ORCPT ); Thu, 28 Jan 2010 02:24:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754880Ab0A1HY2 (ORCPT ); Thu, 28 Jan 2010 02:24:28 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:36344 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754023Ab0A1HY1 (ORCPT ); Thu, 28 Jan 2010 02:24:27 -0500 Date: Thu, 28 Jan 2010 08:24:26 +0100 From: Pavel Machek To: "Rick L. Vinyard, Jr." Cc: Jiri Kosina , Oliver Neukum , linux-kernel@vger.kernel.org, felipe.balbi@nokia.com, jayakumar.lkml@gmail.com, linux-fbdev@vger.kernel.org, krzysztof.h1@wp.pl, akpm@linux-foundation.org, linux-usb@vger.kernel.org, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com Subject: Re: [PATCH] hid: Logitech G13 driver 0.0.4 Message-ID: <20100128072425.GA25633@atrey.karlin.mff.cuni.cz> References: <201001202047.o0KKlMTr014003@mustang.cs.nmsu.edu> <201001202219.12058.oliver@neukum.org> <8512e098224714ed7d54c62b46346796.squirrel@intranet.cs.nmsu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8512e098224714ed7d54c62b46346796.squirrel@intranet.cs.nmsu.edu> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1125 Lines: 28 Hi! > is because it appears there are two conditions that fb_sys_write() will > continue on to the copy_from_user() but still return an error code. In > these cases -EFBIG and -ENOSPEC are returned but it is possible the buffer > has still been modified. > > Again, like I said, I don't have a problem changing it. If it's wrong, > it's wrong no matter how many other drivers may take the same > approach. I believe it is wrong. > My intuition tells me it's wrong, but at the same time I'd like to know if > there's a reason behind the other drivers also ignoring the EFAULT. Or, > perhaps it simply started in one driver and everyone else patterned after > it just like I did the g13 driver. I guess it is indeed a copy&paste problem... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/