Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755562Ab0A1Pho (ORCPT ); Thu, 28 Jan 2010 10:37:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755179Ab0A1Phn (ORCPT ); Thu, 28 Jan 2010 10:37:43 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:41679 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754640Ab0A1Phn (ORCPT ); Thu, 28 Jan 2010 10:37:43 -0500 Date: Thu, 28 Jan 2010 10:37:41 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: "Rafael J. Wysocki" cc: pm list , LKML Subject: Re: [PATCH 1/2] PM / Runtime: Clean up pm_runtime_disable() In-Reply-To: <201001280011.06055.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2209 Lines: 52 On Thu, 28 Jan 2010, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Remove the second argument of __pm_runtime_disable(), which is not > necessary any more, and rename this funtion to pm_runtime_disable(). > Accordingly, drop the static inline definition of > pm_runtime_disable() using __pm_runtime_disable() and export > pm_runtime_disable() as appropriate. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/base/power/runtime.c | 31 ++++--------------------------- > include/linux/pm_runtime.h | 9 ++------- > 2 files changed, 6 insertions(+), 34 deletions(-) > > Index: linux-2.6/drivers/base/power/runtime.c > =================================================================== > --- linux-2.6.orig/drivers/base/power/runtime.c > +++ linux-2.6/drivers/base/power/runtime.c > @@ -943,20 +943,15 @@ int pm_runtime_barrier(struct device *de > EXPORT_SYMBOL_GPL(pm_runtime_barrier); > > /** > - * __pm_runtime_disable - Disable run-time PM of a device. > + * pm_runtime_disable - Disable run-time PM of a device. > * @dev: Device to handle. > - * @check_resume: If set, check if there's a resume request for the device. > * > * Increment power.disable_depth for the device and if was zero previously, > * cancel all pending run-time PM requests for the device and wait for all > * operations in progress to complete. The device can be either active or > * suspended after its run-time PM has been disabled. > - * > - * If @check_resume is set and there's a resume request pending when > - * __pm_runtime_disable() is called and power.disable_depth is zero, the > - * function will wake up the device before disabling its run-time PM. > */ > -void __pm_runtime_disable(struct device *dev, bool check_resume) > +void pm_runtime_disable(struct device *dev) > { Why did you decide to remove the check_resume argument? That decision should be explained in the patch description. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/