Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755751Ab0A1STP (ORCPT ); Thu, 28 Jan 2010 13:19:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755554Ab0A1STO (ORCPT ); Thu, 28 Jan 2010 13:19:14 -0500 Received: from mail-bw0-f227.google.com ([209.85.218.227]:51650 "EHLO mail-bw0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754964Ab0A1STN (ORCPT ); Thu, 28 Jan 2010 13:19:13 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=content-type:to:cc:subject:references:date:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; b=Z9Lv5NmdYl2tCM2cYOMpDLhESq6c8tUAGYFt4mFoYil8fvyMkWg2JGkp4yMZiBrOhN raPKypJGNwgAaraSxHXy9YRCD/t549+8hrdmmAW+TsA1epmZbrPeSTanraaDEgHOy8jb fuz0q1BjTeC+2DTXLys/eZdxK6+aGU52E+igA= Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Michael Reinelt" , "Pekka Enberg" Cc: "Chris Wilson" , "Linus Torvalds" , "A Rojas" , "A. Boulan" , jcnengel@googlemail.com, rientjes@google.com, earny@net4u.de, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, "KOSAKI Motohiro" , "Hugh Dickins" , "Jesse Barnes" , "Eric Anholt" , stable@kernel.org Subject: Re: [PATCH] drm/i915: Selectively enable self-reclaim References: <1264590844-22972-1-git-send-email-chris@chris-wilson.co.uk> <4B602186.8050303@cs.helsinki.fi> <4B610134.9020109@reinelt.co.at> Date: Thu, 28 Jan 2010 19:21:47 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Roman Jarosz" Message-ID: In-Reply-To: <4B610134.9020109@reinelt.co.at> User-Agent: Opera Mail/10.10 (Linux) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1432 Lines: 43 On Thu, 28 Jan 2010 04:15:00 +0100, Michael Reinelt wrote: > > > Pekka Enberg schrieb: >> Chris Wilson kirjoitti: >>> Having missed the ENOMEM return via i915_gem_fault(), there are >>> probably >>> other paths that I also missed. By not enabling NORETRY by default >>> these >>> paths can run the shrinker and take memory from the system (but not >>> from >>> our own inactive lists because our shrinker can not run whilst we hold >>> the struct mutex) and this may allow the system to survive a little >>> longer >>> whilst our drivers consume all available memory. >>> >>> References: >>> OOM killer unexpectedly called with kernel 2.6.32 >>> http://bugzilla.kernel.org/show_bug.cgi?id=14933 >>> >>> Signed-off-by: Chris Wilson >>> Cc: KOSAKI Motohiro >>> Cc: Hugh Dickins >>> Cc: Jesse Barnes >>> Cc: Eric Anholt >>> Cc: stable@kernel.org >> >> Roman, can you give this patch a spin? > > Applied to 2.6.33-rc5, stress-test under heavy load, no problem so far. > Looks fine! Here it works too, thanks! Roman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/