Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755946Ab0A1SZr (ORCPT ); Thu, 28 Jan 2010 13:25:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755796Ab0A1SZq (ORCPT ); Thu, 28 Jan 2010 13:25:46 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:34124 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755567Ab0A1SZn (ORCPT ); Thu, 28 Jan 2010 13:25:43 -0500 Date: Thu, 28 Jan 2010 13:25:28 -0500 From: Christoph Hellwig To: "Jun'ichi Nomura" Cc: Fran?ois Figarola , hch@infradead.org, device-mapper development , linux-kernel@vger.kernel.org, Neil Brown , Andrew Morton , linux-raid@vger.kernel.org, Al Viro Subject: Re: [dm-devel] [BUG] kernel 2.6.32.x hangs during boot process Message-ID: <20100128182528.GA29926@infradead.org> References: <20100122160740.6c16c22d.akpm@linux-foundation.org> <20100128134205.352044bd@notabene> <4B612F89.7020503@ce.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B612F89.7020503@ce.jp.nec.com> User-Agent: Mutt/1.5.19 (2009-01-05) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 26 On Thu, Jan 28, 2010 at 03:32:41PM +0900, Jun'ichi Nomura wrote: > When MS_RDONLY, both freeze_bdev and thaw_bdev call deactivate_locked_super, > which seems wrong. The change was introduced with the commit below: > > commit 4504230a71566785a05d3e6b53fa1ee071b864eb > Author: Christoph Hellwig > Date: Mon Aug 3 23:28:35 2009 +0200 > > freeze_bdev: grab active reference to frozen superblocks > > With the attached patch, both remount-ro and remount-rw are > rejected as EBUSY on freezed device as expected. > > Christoph, do you think this is the right fix? Indeed, this looks wrong in my original code, and the patch looks like the correct fix. Thanks a lot! Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/