Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932208Ab0A1S4S (ORCPT ); Thu, 28 Jan 2010 13:56:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756203Ab0A1S4Q (ORCPT ); Thu, 28 Jan 2010 13:56:16 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42897 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755946Ab0A1S4P (ORCPT ); Thu, 28 Jan 2010 13:56:15 -0500 Date: Thu, 28 Jan 2010 10:54:03 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Yinghai Lu cc: Jesse Barnes , Jeff Garrett , "Rafael J. Wysocki" , Bjorn Helgaas , Linux Kernel Mailing List , Kernel Testers List , Linux PCI , Myron Stowe , Matthew Garrett , Ingo Molnar Subject: Re: [PATCH] x86/pci: print ioh resources only In-Reply-To: <4B61D7C4.1050405@kernel.org> Message-ID: References: <201001261348.59508.rjw@sisk.pl> <201001261032.37053.bjorn.helgaas@hp.com> <201001261902.13911.rjw@sisk.pl> <20100126101752.78196900@jbarnes-piketon> <4B5F735B.2040308@kernel.org> <20100127192409.79af96db@jbarnes-piketon> <20100128040226.GB8964@jgarrett.org> <20100128082432.05a97ebc@jbarnes-piketon> <4B61D7C4.1050405@kernel.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 588 Lines: 19 On Thu, 28 Jan 2010, Yinghai Lu wrote: > @@ -43,7 +43,7 @@ static void __devinit pci_root_bus_res(s > { > u16 word; > u32 dword; > - struct pci_root_info *info; > + struct pci_root_info info; That structure is something like a kilobyte in size, please don't put those things on the stack (sixteen "struct resource" entries). Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/