Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755016Ab0A2Cao (ORCPT ); Thu, 28 Jan 2010 21:30:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754530Ab0A2Can (ORCPT ); Thu, 28 Jan 2010 21:30:43 -0500 Received: from netrider.rowland.org ([192.131.102.5]:45198 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752802Ab0A2Can (ORCPT ); Thu, 28 Jan 2010 21:30:43 -0500 Date: Thu, 28 Jan 2010 21:30:40 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: "Rafael J. Wysocki" cc: pm list , LKML Subject: Re: [PATCH 1/2] PM / Runtime: Clean up pm_runtime_disable() In-Reply-To: <201001282112.48214.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1035 Lines: 26 On Thu, 28 Jan 2010, Rafael J. Wysocki wrote: > > > - * If @check_resume is set and there's a resume request pending when > > > - * __pm_runtime_disable() is called and power.disable_depth is zero, the > > > - * function will wake up the device before disabling its run-time PM. > > > */ > > > -void __pm_runtime_disable(struct device *dev, bool check_resume) > > > +void pm_runtime_disable(struct device *dev) > > > { > > > > Why did you decide to remove the check_resume argument? That decision > > should be explained in the patch description. > > Well, I thought the "which is not necessary any more" would be a sufficient > explanation ... But why is it not necessary now, given that apparently it was necessary before? What has changed to make it unnecessary? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/