Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756655Ab0A2ItL (ORCPT ); Fri, 29 Jan 2010 03:49:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753679Ab0A2ItK (ORCPT ); Fri, 29 Jan 2010 03:49:10 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:41161 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753226Ab0A2ItK (ORCPT ); Fri, 29 Jan 2010 03:49:10 -0500 Date: Fri, 29 Jan 2010 21:48:50 +1300 From: Herbert Xu To: Matt Mackall Cc: dedekind1@gmail.com, Jeff Angielski , linux-mtd@lists.infradead.org, LKML Subject: Re: UBIFS assert failed in ubifs_dirty_inode Message-ID: <20100129084850.GA23140@gondor.apana.org.au> References: <4B591573.60602@theptrgroup.com> <1264480808.2401.78.camel@localhost.localdomain> <1264484928.3536.1017.camel@calx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1264484928.3536.1017.camel@calx> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1054 Lines: 24 On Mon, Jan 25, 2010 at 11:48:48PM -0600, Matt Mackall wrote: > > random: drop weird m_time/a_time manipulation > > No other driver does anything remotely like this that I know of except > for the tty drivers, and I can't see any reason for random/urandom to do > it. In fact, it's a (trivial, harmless) timing information leak. And > obviously, it generates power- and flash-cycle wasting I/O, especially > if combined with something like hwrngd. Also, it breaks ubifs's > expectations. > > Signed-off-by: Matt Mackall Thanks Matt, I'll add this to crypto-2.6 and then stable. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/