Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754480Ab0AaVIx (ORCPT ); Sun, 31 Jan 2010 16:08:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753981Ab0AaVIw (ORCPT ); Sun, 31 Jan 2010 16:08:52 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:49851 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753091Ab0AaVIv (ORCPT ); Sun, 31 Jan 2010 16:08:51 -0500 From: "Rafael J. Wysocki" To: Maxim Levitsky Subject: Re: [RFC][RFT][PATCH] ACPI: Protection from suspending in the middle of EC transaction Date: Sun, 31 Jan 2010 22:09:21 +0100 User-Agent: KMail/1.12.4 (Linux/2.6.33-rc6-rjw; KDE/4.3.5; x86_64; ; ) Cc: ACPI Devel Maling List , Alexey Starikovskiy , Len Brown , pm list , Thomas Renninger , Matthew Garrett , LKML References: <201001310029.48717.rjw@sisk.pl> <1264970500.5544.0.camel@maxim-laptop> In-Reply-To: <1264970500.5544.0.camel@maxim-laptop> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201001312209.21212.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 25 On Sunday 31 January 2010, Maxim Levitsky wrote: > On Sun, 2010-01-31 at 00:29 +0100, Rafael J. Wysocki wrote: ... > > > > static int acpi_ec_resume(struct acpi_device *device) > > { > > struct acpi_ec *ec = acpi_driver_data(device); > > + > > + mutex_lock(&ec->lock); > > /* Enable use of GPE back */ > > acpi_enable_gpe(NULL, ec->gpe); > > + /* Allow transactions to happen again */ > > + set_bit(EC_FLAGS_SUSPENDED, &ec->flags); > ^^^^^^^^^^^^ > Thats why it doesn't work here.... > Will retest now. Ouch, sorry. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/