Date: Wed, 20 Jan 2010 09:10:20 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: linux-kernel@vger.kernel.org, Jack Steiner <steiner@sgi.com>,
       "H. Peter Anvin" <hpa@zytor.com>, tglx@linutronix.de
Subject: Re: [PATCH] x86, UV: Fix RTC latency bug by reading replicated
 cachelines
Message-ID: <20100120081020.GG20621@elte.hu>
References: <20100112210904.GA24546@sgi.com>
 <20100113092433.GB6739@elte.hu>
 <20100114183422.GA12152@sgi.com>
 <20100119144137.GB22276@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100119144137.GB22276@sgi.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1215
Lines: 36


* Dimitri Sivanich <sivanich@sgi.com> wrote:

> +++ linux/drivers/char/uv_mmtimer.c	2010-01-14 11:56:57.000000000 -0600
> @@ -89,12 +89,19 @@ static long uv_mmtimer_ioctl(struct file
>  	switch (cmd) {
>  	case MMTIMER_GETOFFSET:	/* offset of the counter */
>  		/*
> -		 * UV RTC register is on its own page
> +		 * Starting with HUB rev 2.0, the UV RTC register is
> +		 * replicated across all cachelines of it's own page.
> +		 * This allows faster simultaneous reads from a given socket.
> +		 *
> +		 * The offset returned is in 64 bit units.
>  		 */
> -		if (PAGE_SIZE <= (1 << 16))
> -			ret = ((UV_LOCAL_MMR_BASE | UVH_RTC) & (PAGE_SIZE-1))
> -				/ 8;
> -		else
> +		if (PAGE_SIZE <= (1 << 16)) {
> +			if (uv_get_min_hub_revision_id() == 1)
> +				ret = 0;
> +			else
> +				ret = ((uv_blade_processor_id() *
> +					L1_CACHE_BYTES) % PAGE_SIZE) / 8;
> +		} else

That 64K PAGE_SIZE check in the ioctl looks rather weird. What is the purpose 
of it?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/