Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754785Ab0BACKP (ORCPT ); Sun, 31 Jan 2010 21:10:15 -0500 Received: from gate.crashing.org ([63.228.1.57]:55909 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940Ab0BACKM (ORCPT ); Sun, 31 Jan 2010 21:10:12 -0500 Subject: Re: [PATCH] nodmask.h: remove macro any_online_node From: Benjamin Herrenschmidt To: H Hartley Sweeten Cc: Linux Kernel , linuxppc-dev@ozlabs.org, devicetree-discuss@lists.ozlabs.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, akpm@linux-foundation.org, rientjes@google.com, kamezawa.hiroyu@jp.fujitsu.com, mel@csn.ul.ie, lee.schermerhorn@hp.com, paulus@samba.org, dave@linux.vnet.ibm.com, miltonm@bga.com, nfont@austin.ibm.com, geoffrey.levand@am.sony.com, grant.likely@secretlab.ca, bfields@fieldses.org, neilb@suse.de, Trond.Myklebust@netapp.com, davem@davemloft.net, bhalevy@panasas.com, chuck.lever@oracle.com, Ricardo.Labiaga@netapp.com In-Reply-To: <201001061624.59118.hartleys@visionengravers.com> References: <201001061624.59118.hartleys@visionengravers.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 01 Feb 2010 13:05:58 +1100 Message-ID: <1264989958.8287.13.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1639 Lines: 41 On Wed, 2010-01-06 at 16:24 -0700, H Hartley Sweeten wrote: > nodmask.h: remove macro any_online_node > > The macro any_online_node is prone to producing sparse warnings > due to the local symbol 'node'. Since all the in-tree users are really > requesting the first online node (the mask argument is either > NODE_MASK_ALL or node_online_map) just use the first_online_node > macro and remove the any_online_node macro since there are no users. > > Signed-off-by: H Hartley Sweeten > Cc: Andrew Morton > Cc: David Rientjes > Cc: KAMEZAWA Hiroyuki > Cc: Mel Gorman > Cc: Lee Schermerhorn Acked-by: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Dave Hansen > Cc: Milton Miller > Cc: Nathan Fontenot > Cc: Geoff Levand > Cc: Grant Likely > Cc: J. Bruce Fields > Cc: Neil Brown > Cc: Trond Myklebust > Cc: David S. Miller > Cc: Benny Halevy > Cc: Chuck Lever > Cc: Ricardo Labiaga Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/