Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752497Ab0AOIH6 (ORCPT ); Fri, 15 Jan 2010 03:07:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752146Ab0AOIH5 (ORCPT ); Fri, 15 Jan 2010 03:07:57 -0500 Received: from ey-out-2122.google.com ([74.125.78.25]:25268 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751138Ab0AOIH4 (ORCPT ); Fri, 15 Jan 2010 03:07:56 -0500 Message-ID: <4B5021F8.4010703@monstr.eu> Date: Fri, 15 Jan 2010 09:06:16 +0100 From: Michal Simek Reply-To: monstr@monstr.eu User-Agent: Thunderbird 2.0.0.22 (X11/20090625) MIME-Version: 1.0 To: H Hartley Sweeten CC: Linux Kernel , linux-sh@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au, x86@kernel.org, mingo@redhat.com, tglx@linutronix.de, lethal@linux-sh.org, hpa@zytor.com Subject: Re: [PATCH] cpuinfo_op: consolidate extern declaration References: <201001141158.09795.hartleys@visionengravers.com> In-Reply-To: <201001141158.09795.hartleys@visionengravers.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org H Hartley Sweeten wrote: > cpuinfo_op: consolidate extern declaration > > All the architectures supported by the kernel also support > /proc/cpuinfo. Only a couple actually declare the seq_operations > as extern. All the others will produce a sparse warning like: > > warning: symbol 'cpuinfo_op' was not declared. Should it be static? > > Fix all the warnings and consolidate the declaration by putting it > in . > > Signed-off-by: H Hartley Sweeten > Cc: Ingo Molnar > Cc: Thomas Gleixner > Cc: Michal Simek > Cc: Paul Mundt > Cc: H. Peter Anvin > Tested-by: Michal Simek -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/