Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755958Ab0AOKg2 (ORCPT ); Fri, 15 Jan 2010 05:36:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752085Ab0AOKg1 (ORCPT ); Fri, 15 Jan 2010 05:36:27 -0500 Received: from cantor.suse.de ([195.135.220.2]:44999 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297Ab0AOKg0 (ORCPT ); Fri, 15 Jan 2010 05:36:26 -0500 Date: Fri, 15 Jan 2010 11:36:25 +0100 (CET) From: Jiri Kosina To: H Hartley Sweeten Cc: Linux Kernel , linux-input@vger.kernel.org Subject: Re: [PATCH] hid-debug.c: make local symbols static In-Reply-To: <201001141910.08225.hartleys@visionengravers.com> Message-ID: References: <201001141910.08225.hartleys@visionengravers.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jan 2010, H Hartley Sweeten wrote: > hid-debug.c: make local symbols static > > The symbols hid_resolv_event and hid_dump_input_mapping > are only used locally in this file. Make them static to prevent > the following sparse warnings: > > warning: symbol 'hid_resolv_event' was not declared. Should it be static? > warning: symbol 'hid_dump_input_mapping' was not declared. Should it be static? > > Signed-off-by: H Hartley Sweeten > Cc: Jiri Kosina > > --- > > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c > index 6abd036..cd4ece6 100644 > --- a/drivers/hid/hid-debug.c > +++ b/drivers/hid/hid-debug.c > @@ -864,13 +864,13 @@ static const char **names[EV_MAX + 1] = { > [EV_SND] = sounds, [EV_REP] = repeats, > }; > > -void hid_resolv_event(__u8 type, __u16 code, struct seq_file *f) { > - > +static void hid_resolv_event(__u8 type, __u16 code, struct seq_file *f) > +{ > seq_printf(f, "%s.%s", events[type] ? events[type] : "?", > names[type] ? (names[type][code] ? names[type][code] : "?") : "?"); > } > > -void hid_dump_input_mapping(struct hid_device *hid, struct seq_file *f) > +static void hid_dump_input_mapping(struct hid_device *hid, struct seq_file *f) > { > int i, j, k; > struct hid_report *report; Applied, thanks. -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/