From: "Mahalingam, Nithish" <nithish.mahalingam@intel.com>
To: "avorontsov@ru.mvista.com" <avorontsov@ru.mvista.com>
CC: "dwmw2@infradead.org" <dwmw2@infradead.org>, "cbou@mail.ru" <cbou@mail.ru>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date: Fri, 15 Jan 2010 18:49:15 +0530
Subject: RE: [RFC] [PATCH] Adding Intel Moorestown PMIC Battery Driver
Thread-Topic: [RFC] [PATCH] Adding Intel Moorestown PMIC Battery Driver
Thread-Index: AcqV5GfLM2id1JTnR8eraaDuxr4cGgAAKQxA
Message-ID: <175E0F9A9EFCEA46A65F5552BB0572980445DB321C@bgsmsx502.gar.corp.intel.com>
References: <175E0F9A9EFCEA46A65F5552BB0572980445D2BE30@bgsmsx502.gar.corp.intel.com>
 <20100111213242.GA3985@oksana.dev.rtsoft.ru>
 <175E0F9A9EFCEA46A65F5552BB0572980445DB31FB@bgsmsx502.gar.corp.intel.com>
 <20100115131229.GA30213@oksana.dev.rtsoft.ru>
In-Reply-To: <20100115131229.GA30213@oksana.dev.rtsoft.ru>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit

>>>> +       unsigned int batt_charge_now;           /* in mAS */
>>>> +       unsigned int batt_prev_charge_full;     /* in mAS */
>>> +       unsigned int batt_charge_rate;          /* in units per second */
>>> 
>>> Per include/linux/power_supply.h and
>>> Documentation/power/power_supply_class.txt
>>> 
>>> * All voltages, currents, charges, energies, time and temperatures in uV,
>>> * uA, uAh, uWh, seconds and tenths of degree Celsius unless otherwise
>>> * stated. It's driver's job to convert its raw values to units in which
>>> * this class operates.
>> 
>> I just now checked the hardware spec and it is indeed mAh. I will correct 
>> the comment appropriately.
> 
> Note, if the hardware reports the values in mAh (milli), the driver
> still have to convert them to uAh (micro) before reporting the values
> to userspace.

Yup will take care, sorry for not making it clear here.


Regards,
Nithish
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?