Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932344Ab0AOURd (ORCPT ); Fri, 15 Jan 2010 15:17:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758211Ab0AOUQt (ORCPT ); Fri, 15 Jan 2010 15:16:49 -0500 Received: from kroah.org ([198.145.64.141]:51575 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758203Ab0AOUQs (ORCPT ); Fri, 15 Jan 2010 15:16:48 -0500 Date: Fri, 15 Jan 2010 10:54:57 -0800 From: Greg KH To: Eirik Aanonsen Cc: "kernel@avr32linux.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/1] atmel uaba : Adding invert vbus_pin Message-ID: <20100115185457.GG12146@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2010 at 02:01:59PM +0100, Eirik Aanonsen wrote: > Adding vbus_pin_inverted so that the usb detect pin can be active high or low. > This because depending on HW implementation it is better to have active low. > Also replaced the pio_get_value(udc->vbus_pin); with a call to vbus_is_present(udc); > > Signed-off-by: Eirik Aanonsen Please always run your patches through 'scripts/checkpatch.pl' before sending them so that you don't accidentally add coding style errors. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/