Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758248Ab0AOUTM (ORCPT ); Fri, 15 Jan 2010 15:19:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758196Ab0AOUTL (ORCPT ); Fri, 15 Jan 2010 15:19:11 -0500 Received: from e37.co.us.ibm.com ([32.97.110.158]:38938 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476Ab0AOUTK (ORCPT ); Fri, 15 Jan 2010 15:19:10 -0500 Subject: Re: [RFC] [PATCH 3/7] Execution out of line (XOL) From: Jim Keniston To: Peter Zijlstra Cc: Srikar Dronamraju , Ingo Molnar , Arnaldo Carvalho de Melo , Ananth N Mavinakayanahalli , utrace-devel , Frederic Weisbecker , Masami Hiramatsu , Maneesh Soni , Mark Wielaard , LKML In-Reply-To: <1263546455.4244.348.camel@laptop> References: <20100111122521.22050.3654.sendpatchset@srikar.in.ibm.com> <20100111122545.22050.64994.sendpatchset@srikar.in.ibm.com> <1263467318.4244.289.camel@laptop> <1263508997.4875.32.camel@localhost.localdomain> <1263546455.4244.348.camel@laptop> Content-Type: text/plain Date: Fri, 15 Jan 2010 12:18:51 -0800 Message-Id: <1263586731.5007.2.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-8.el5_2.3) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2010-01-15 at 10:07 +0100, Peter Zijlstra wrote: > On Thu, 2010-01-14 at 14:43 -0800, Jim Keniston wrote: > > > > Yeah, there's not a lot of context there. I hope it will make more > > sense if you read section 1.1 of Documentation/uprobes.txt (patch #6). > > Or look at get_insn_slot() in kprobes, and understand that we're trying > > to do something similar in uprobes, where the instruction copies have to > > reside in the user address space of the probed process. > > That's not the point, changelogs shoulnd not be this cryptic. They > should be stand alone and descriptive of what, why and how. Point taken. > > If you can't be bothered writing such for something you want reviewed > for inclusion then I might not be bothered looking at them at all. > We appreciate your persistence wrt this patch set. :-} Jim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/