Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753358Ab0APPh1 (ORCPT ); Sat, 16 Jan 2010 10:37:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752546Ab0APPh0 (ORCPT ); Sat, 16 Jan 2010 10:37:26 -0500 Received: from einhorn.in-berlin.de ([192.109.42.8]:57416 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752099Ab0APPhZ (ORCPT ); Sat, 16 Jan 2010 10:37:25 -0500 X-Envelope-From: stefanr@s5r6.in-berlin.de Message-ID: <4B51DD22.4040404@s5r6.in-berlin.de> Date: Sat, 16 Jan 2010 16:37:06 +0100 From: Stefan Richter User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.23) Gecko/20100102 SeaMonkey/1.1.18 MIME-Version: 1.0 To: Thiago Farina CC: linux-kernel@vger.kernel.org, Willem Riede , "James E.J. Bottomley" , James Bottomley , FUJITA Tomonori , osst-users@lists.sourceforge.net, linux-scsi@vger.kernel.org Subject: Re: [PATCH] scsi/osst.c: remove unncessary casting of kmalloc. References: <503939f4cfd0b8c362a2f5a103285f8dc330b99a.1263651173.git.tfransosi@gmail.com> <4B51DCBF.9090902@s5r6.in-berlin.de> In-Reply-To: <4B51DCBF.9090902@s5r6.in-berlin.de> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stefan Richter wrote: > Thiago Farina wrote: >> - os_scsi_tapes = >> - (struct osst_tape **)kmalloc(osst_max_dev * sizeof(struct osst_tape *), >> - GFP_ATOMIC); >> + os_scsi_tapes = kmalloc(osst_max_dev * sizeof(struct osst_tape *), >> + GFP_ATOMIC); > Since you update the style of this kmalloc usage, you could at the same > time change the sizeof expression to sizeof(* os_scsi_tapes). PS: osst_max_dev * sizeof(* os_scsi_tapes) of course, if it wasn't obvious. -- Stefan Richter -=====-==-=- ---= =---- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/