DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=LEEU69dUkXRz2omDp8EALQIoid0V0X5DDdf1GVQ4KcAzIAxR7aBWNbgXarhdHUYf2g
         Gm/WOb7FlwRFlVpMaOKHhd2YKyHMcXDXV8BvADt3XpYV3Gj2+RpjtBhWciaG5sUO+s45
         x7jFkW7F1UiOI6tPxwDwz4VtoPIFzMq10dbzk=
MIME-Version: 1.0
In-Reply-To: <14385191E87B904DBD836449AA30269D021A4A@MORGANITE.micrel.com>
References: <14385191E87B904DBD836449AA30269D021A4A@MORGANITE.micrel.com>
Date: Sat, 16 Jan 2010 17:00:30 +0100
Message-ID: <e2d7436a1001160800u11206f54iaf07bb92331a256a@mail.gmail.com>
Subject: Re: [PATCH 2.6.33 1/3] net: Micrel KSZ8841/2 PCI Ethernet driver
From: =?ISO-8859-2?Q?Micha=B3_Miros=B3aw?= <mirqus@gmail.com>
To: "Ha, Tristram" <Tristram.Ha@micrel.com>
Cc: Dave Miller <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Michael Buesch <mb@bu3sch.de>,
        Felix Fietkau <openwrt@nbd.name>
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org

Hello,

2010/1/16 Ha, Tristram <Tristram.Ha@micrel.com>:
> This is a new network driver for Micrel KSZ8841/KSZ8842 PCI Ethernet chips. ?The same driver can run both chips at the same time. ?It supports IPv4 TCP hardware checksumming and so can use scatter/gather transmission.
>
> The KSZ8842 has a switch with lots of hardware configurations. ?The driver uses the proc system to allow users to configure the switch. ?If this is not desired the whole thing can be removed by not calling the init_proc() function.
>
> The KSZ8842 switch has 2 ports. ?Some users like to take direct control of those ports. ?So KSZ8842 has a multiple devices mode in which the driver creates another network device so that users can specify which port to send packets. ?This mode is enabled by passing the "multi_dev=1" parameter to the driver during loading.
[...]

I briefly looked over the datasheet for your device and it looks like
it has the same basic design idea as a "ROBO" switch from Broadcom
that is used in bcm53xx SoCs. This can be seen as a 3-port switch with
one port fixed to be link to CPU (a special kind of PHY).

If my assumptions are correct, then I thing it would be better to have
a driver that presents this device as two: one - an ethernet device,
and second - a switch management interface like the one used in
OpenWRT.

Here are some links for reference:
http://downloads.openwrt.org/kamikaze/8.09.2/kamikaze_8.09.2_source.tar.bz2;
subdir: package/switch/src/
  -> switch management driver for ADMTEK Adm6996 and Broadcom BCM5325E/536x

(I'm adding switch driver's authors to CC list. I hope I picket the
correct address for Felix from 3 in the sources. :-)

Best Regards,
Micha? Miros?aw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/