Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753346Ab0BAKZ0 (ORCPT ); Mon, 1 Feb 2010 05:25:26 -0500 Received: from mail-iw0-f186.google.com ([209.85.223.186]:53009 "EHLO mail-iw0-f186.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424Ab0BAKZZ convert rfc822-to-8bit (ORCPT ); Mon, 1 Feb 2010 05:25:25 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Iq+u1ZAhq/4tvLXNFRPU1MS1p42jQ758PeK+4968BZev74d+0GCV8zw1tYihs7OgRu qHlciTWHppUFjNpJjz8sFpHzornwZaHw6ht/xDwcTPnDiRkRzqufV5l7z7KKHR3kTqlW iobF04DrQY3GLTd5/AGLzGpSgg9KMP/MOhChQ= MIME-Version: 1.0 In-Reply-To: <1265019160.2848.14.camel@edumazet-laptop> References: <1264813832.2793.446.camel@tonnant> <1264816634.2793.505.camel@tonnant> <1264816777.2793.510.camel@tonnant> <1264834704.2919.3.camel@edumazet-laptop> <1265016745.7499.144.camel@tonnant> <1265019160.2848.14.camel@edumazet-laptop> Date: Mon, 1 Feb 2010 12:25:24 +0200 Message-ID: Subject: Re: debug: nt_conntrack and KVM crash From: Alexey Dobriyan To: Eric Dumazet Cc: Jon Masters , linux-kernel , netdev , netfilter-devel , Patrick McHardy Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1499 Lines: 38 On Mon, Feb 1, 2010 at 12:12 PM, Eric Dumazet wrote: > Le lundi 01 f?vrier 2010 ? 11:36 +0200, Alexey Dobriyan a ?crit : >> On Mon, Feb 1, 2010 at 11:32 AM, Jon Masters wrote: >> > I hacked up a per-namespace version of hashtables (this needs doing >> > anyway, since the global stuff is just waiting to break) >> >> Which ones? Conntrack hashtables are per-netns. > > It seems they are, but this is not a complete work : They are per-netns. It's not "complete", because right now there is no point in doing more. nf_conntrack_max was rejected given the absense of per-netns kernel memory consumption limiting. > 1) Global settings (shared by all netns) Only hashtable size which is module parameter and there is no generic way to limit kernel memory (like beancounters). > 2) nf_conntrack_cachep is shared, it should be not shared. There is no need for it to be shared, unless you measured something. > 3) nf_conntrack_untracked shared by all netns, it should be local. > > nf_conntrack_cleanup_net() can block forever because of this. > > while (atomic_read(&nf_conntrack_untracked.ct_general.use) > 1) > ? ? ? ?schedule(); This is known, yes, thinking on it, as naive way was agreed to suck. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/