Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754030Ab0BAKgG (ORCPT ); Mon, 1 Feb 2010 05:36:06 -0500 Received: from dallas.jonmasters.org ([72.29.103.172]:53360 "EHLO dallas.jonmasters.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753157Ab0BAKgE (ORCPT ); Mon, 1 Feb 2010 05:36:04 -0500 Subject: Re: debug: nt_conntrack and KVM crash From: Jon Masters To: Alexey Dobriyan Cc: Eric Dumazet , linux-kernel , netdev , netfilter-devel , Patrick McHardy In-Reply-To: References: <1264813832.2793.446.camel@tonnant> <1264816634.2793.505.camel@tonnant> <1264816777.2793.510.camel@tonnant> <1264834704.2919.3.camel@edumazet-laptop> <1265016745.7499.144.camel@tonnant> Content-Type: text/plain Organization: World Organi[sz]ation of Broken Dreams Date: Mon, 01 Feb 2010 05:35:52 -0500 Message-Id: <1265020552.7499.147.camel@tonnant> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-SA-Do-Not-Run: Yes X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: jonathan@jonmasters.org X-SA-Exim-Scanned: No (on dallas.jonmasters.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1068 Lines: 25 On Mon, 2010-02-01 at 11:36 +0200, Alexey Dobriyan wrote: > On Mon, Feb 1, 2010 at 11:32 AM, Jon Masters wrote: > > I hacked up a per-namespace version of hashtables (this needs doing > > anyway, since the global stuff is just waiting to break) > > Which ones? Conntrack hashtables are per-netns. They are, but the metadata is not. Sorry for not being clear, but my previous mail was. i.e. there is a per-netns hashtable that is indexed using a global that might change at any time underneath. The htable size and max should be per-netns too. An existing sysctl/module parameter affects these and should also ultimately either iterate through namespaces, or only affect the global init_net (as it almost does now, except it changes the data used by the others and doesn't resize them). Jon. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/