Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754638Ab0BAN4h (ORCPT ); Mon, 1 Feb 2010 08:56:37 -0500 Received: from mail-bw0-f223.google.com ([209.85.218.223]:34379 "EHLO mail-bw0-f223.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297Ab0BAN4g (ORCPT ); Mon, 1 Feb 2010 08:56:36 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=Bb1BxC5YXzS4Z7Ze0OCpe1Ji2lTp+LWyGfrCRTWfKXGHyGba0zsTJBVlRww33/39WI PdwsCexec5IE5J35zIFseiagkqo5NlA8PiZaipalFvPsSCAGVj8rKjemRwpqwrscJ0ad VIS9SLf6TslYwnuSZMZyjwqTVUNuPx5H2Eddc= Subject: Re: [PATCH] af_key: fix netns ops ordering on module load/unload From: Eric Dumazet To: Luca Tettamanti Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, David Miller In-Reply-To: <68676e01002010550l2654208dged864973a996c381@mail.gmail.com> References: <20100129094822.GA8294@nb-core2.darkstar.lan> <1264778549.3184.28.camel@edumazet-laptop> <1264782806.3184.42.camel@edumazet-laptop> <20100130125327.GA4258@x200> <68676e01002010550l2654208dged864973a996c381@mail.gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 01 Feb 2010 14:56:30 +0100 Message-ID: <1265032590.2848.40.camel@edumazet-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1535 Lines: 37 Le lundi 01 février 2010 à 14:50 +0100, Luca Tettamanti a écrit : > On Sat, Jan 30, 2010 at 1:53 PM, Alexey Dobriyan wrote: > > [PATCH] af_key: fix netns ops ordering on module load/unload > > > > 1. After sock_register() returns, it's possible to create sockets, > > even if module still not initialized fully (blame generic module code > > for that!) > > 2. Consequently, pfkey_create() can be called with pfkey_net_id still not > > initialized which will BUG_ON in net_generic(): > > kernel BUG at include/net/netns/generic.h:43! > > 3. During netns shutdown, netns ops should be unregistered after > > key manager unregistered because key manager calls can be triggered > > from xfrm_user module: > > > > general protection fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC > > pfkey_broadcast+0x111/0x210 [af_key] > > pfkey_send_notify+0x16a/0x300 [af_key] > > km_state_notify+0x41/0x70 > > xfrm_flush_sa+0x75/0x90 [xfrm_user] > > 4. Unregister netns ops after socket ops just in case and for symmetry. > > > > Reported by Luca Tettamanti. > > > > Signed-off-by: Alexey Dobriyan > > Tested-by: Luca Tettamanti Signed-off-by: Eric Dumazet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/