Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754684Ab0BAOAJ (ORCPT ); Mon, 1 Feb 2010 09:00:09 -0500 Received: from stinky.trash.net ([213.144.137.162]:38426 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753953Ab0BAOAH (ORCPT ); Mon, 1 Feb 2010 09:00:07 -0500 Message-ID: <4B66DE62.8080801@trash.net> Date: Mon, 01 Feb 2010 15:00:02 +0100 From: Patrick McHardy User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: Jan Engelhardt CC: "Helight.Xu" , netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org Subject: Re: [REPORT] may be wrong place #endif in include/linux/netfilter_ipv4.h References: <4B64E732.3090507@gmail.com> In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1450 Lines: 39 Jan Engelhardt wrote: > On Sunday 2010-01-31 03:13, Helight.Xu wrote: > >> hi all gys: >> >> when I make LKM with netfilter on "NF_IP_PRE_ROUTING" point, but it was >> reported that "NF_IP_PRE_ROUTING" is not defined. >> >> but I am surely including , when I opened >> include/linux/netfilter_ipv4.h I found that >> "NF_IP_PRE_ROUTING" is in this lable : >> #ifndef __KERNEL__ >> ..... >> /* IP Hooks */ >> /* After promisc drops, checksum checks. */ >> #define NF_IP_PRE_ROUTING 0 >> /* If the packet is destined for this box. */ >> #define NF_IP_LOCAL_IN 1 >> /* If the packet is destined for another interface. */ >> #define NF_IP_FORWARD 2 >> /* Packets coming from a local process. */ >> #define NF_IP_LOCAL_OUT 3 >> /* Packets about to hit the wire. */ >> #define NF_IP_POST_ROUTING 4 >> #define NF_IP_NUMHOOKS 5 >> #endif /* ! __KERNEL__ */ >> >> So I think the "endif" is ended a little early! > > Seems so. Are there any out-of-tree nf_ip_hook_priorities users? If not, > we could possibly move it further below. Its only available for userspace for compatibility reasons, the kernel doesn't use the old definitions. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/