Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755210Ab0BAPpz (ORCPT ); Mon, 1 Feb 2010 10:45:55 -0500 Received: from fg-out-1718.google.com ([72.14.220.156]:61144 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752371Ab0BAPpx (ORCPT ); Mon, 1 Feb 2010 10:45:53 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=Z1rVr3FC/XxF2rp4RTceVprzRZd+k4uVPk1ofvcoKHiNMPZ8oQaopS/Uv3JMLoN6UJ Bbhp5Zj6W694AaSt8hjPb+0mwz8ywwEtvaGhoE94WJ7WI+wJvCXE7j1cgRzfIfEyRJUM 8Mi5TcZuXkscOtmS7gQ+e8RVYGx45DdxOVZMI= Subject: Re: [PATCH] Port ricoh_mmc to pci quirk From: Maxim Levitsky To: Wolfram Sang Cc: Andrew Morton , Philip Langdale , Pierre Ossman , linux-kernel , linux-mmc@vger.kernel.org In-Reply-To: <1264886914-30179-1-git-send-email-maximlevitsky@gmail.com> References: <1264772255.4620.3.camel@maxim-laptop> <1264886914-30179-1-git-send-email-maximlevitsky@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 01 Feb 2010 17:45:47 +0200 Message-ID: <1265039147.3785.9.camel@maxim-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 26 On Sat, 2010-01-30 at 23:28 +0200, Maxim Levitsky wrote: > This patch solves nasty problem original driver had. > Original goal of the ricoh_mmc, was to disable this device because > then, mmc cards can be read using standard SDHCI controller, > thus avoiding the need in yet another driver. > However, the act of disablement, makes other pci functions that belong to > this controller (xD and memstick) shift up one level, thus pci core has now wrong idea > about these devices. > > To fix this issue, this patch moves the driver into pci quirk section, thus it > is executed before the pci is enumerated, and therefore solve that issue, > also the same is preformed on resume for same reasons. > > Also regardless of the above, this way is cleaner. You probably didn't notice that patch, because I used git-send-email, and forgot to set subject properly. This meant to be next version of this patch. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/