Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754942Ab0BASCf (ORCPT ); Mon, 1 Feb 2010 13:02:35 -0500 Received: from cpsmtpm-eml102.kpnxchange.com ([195.121.3.6]:65453 "EHLO CPSMTPM-EML102.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754184Ab0BASCe (ORCPT ); Mon, 1 Feb 2010 13:02:34 -0500 From: Frans Pop To: James Bottomley Subject: Re: [PATCH 05/10] drivers/scsi/arcmsr: Fix continuation line formats Date: Mon, 1 Feb 2010 19:02:31 +0100 User-Agent: KMail/1.9.9 Cc: joe@perches.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org References: <1a318fa326c6ab2584b9d318bd1538e7f7debbdf.1264967499.git.joe@perches.com> <1a318fa326c6ab2584b9d318bd1538e7f7debbdf.1264967499.git.joe@perches.com> <1265044616.6910.15.camel@mulgrave.site> In-reply-To: <1265044616.6910.15.camel@mulgrave.site> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201002011902.33015.elendil@planet.nl> X-OriginalArrivalTime: 01 Feb 2010 18:02:33.0239 (UTC) FILETIME=[BA61FA70:01CAA368] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 698 Lines: 17 James Bottomley wrote: >> - printk(KERN_NOTICE "arcmsr%d: wait 'flush adapter cache' \ >> - timeout, retry count down = %d \n", acb->host->host_no, retry_count); > > So I might personally dislike this style The problem here is not style, but that the whitespace of the indentation on the second line becomes part of the output! That makes the code defective and is why Joe posted the patch series. Cheers, FJP -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/