Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755445Ab0BASXI (ORCPT ); Mon, 1 Feb 2010 13:23:08 -0500 Received: from liberdade.minaslivre.org ([72.232.254.139]:37183 "EHLO liberdade.minaslivre.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755304Ab0BASXG (ORCPT ); Mon, 1 Feb 2010 13:23:06 -0500 From: Thadeu Lima de Souza Cascardo To: Arnd Bergmann Cc: Thadeu Lima de Souza Cascardo , Samuel Ortiz , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] irda: remove BKL from irnet open function Date: Mon, 1 Feb 2010 16:18:40 -0200 Message-Id: <1265048321-8097-1-git-send-email-cascardo@holoscopio.com> X-Mailer: git-send-email 1.6.6.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1352 Lines: 45 Commit cddf63d99d0d145f18b293c3d0de4af7dab2a922 has push down the BKL into irnet open function. However, there's nothing that needs locking in there. Signed-off-by: Thadeu Lima de Souza Cascardo --- net/irda/irnet/irnet_ppp.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/net/irda/irnet/irnet_ppp.c b/net/irda/irnet/irnet_ppp.c index 156020d..d6b502c 100644 --- a/net/irda/irnet/irnet_ppp.c +++ b/net/irda/irnet/irnet_ppp.c @@ -479,7 +479,6 @@ dev_irnet_open(struct inode * inode, ap = kzalloc(sizeof(*ap), GFP_KERNEL); DABORT(ap == NULL, -ENOMEM, FS_ERROR, "Can't allocate struct irnet...\n"); - lock_kernel(); /* initialize the irnet structure */ ap->file = file; @@ -501,7 +500,6 @@ dev_irnet_open(struct inode * inode, { DERROR(FS_ERROR, "Can't setup IrDA link...\n"); kfree(ap); - unlock_kernel(); return err; } @@ -512,7 +510,6 @@ dev_irnet_open(struct inode * inode, file->private_data = ap; DEXIT(FS_TRACE, " - ap=0x%p\n", ap); - unlock_kernel(); return 0; } -- 1.6.6.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/