Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755563Ab0BASal (ORCPT ); Mon, 1 Feb 2010 13:30:41 -0500 Received: from mail.perches.com ([173.55.12.10]:1710 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755274Ab0BASak (ORCPT ); Mon, 1 Feb 2010 13:30:40 -0500 Subject: Re: [PATCH 01/10] arch/powerpc: Fix continuation line formats From: Joe Perches To: Benjamin Herrenschmidt Cc: linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@ozlabs.org In-Reply-To: <1264990574.8287.15.camel@pasglop> References: <1264990574.8287.15.camel@pasglop> Content-Type: text/plain; charset="UTF-8" Date: Mon, 01 Feb 2010 10:30:37 -0800 Message-ID: <1265049037.25140.301.camel@Joe-Laptop.home> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1021 Lines: 29 On Mon, 2010-02-01 at 13:16 +1100, Benjamin Herrenschmidt wrote: > On Sun, 2010-01-31 at 12:02 -0800, Joe Perches wrote: > > String constants that are continued on subsequent lines with \ > > are not good. > > Signed-off-by: Joe Perches > You want me to take that in the powerpc tree ? Yes please. > A minor glitch below tho... > > @@ -349,7 +349,7 @@ static int __init nvram_create_os_partition(void) > > rc = ppc_md.nvram_write((char *)&seq_init, sizeof(seq_init), &tmp_index); > > if (rc <= 0) { > > printk(KERN_ERR "nvram_create_os_partition: nvram_write " > > - "failed (%d)\n", rc); > > + "failed (%d)\n", rc); > > return rc; > > } > > The above is objectionable :-) Can you drop that section or do you need another patch? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/