Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755498Ab0BAWkm (ORCPT ); Mon, 1 Feb 2010 17:40:42 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:56012 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752919Ab0BAWki (ORCPT ); Mon, 1 Feb 2010 17:40:38 -0500 From: Andreas Schwab To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux@arm.linux.org.uk, dhowells@redhat.com, ysato@users.sourceforge.jp, tony.luck@intel.com, geert@linux-m68k.org, zippel@linux-m68k.org, gerg@uclinux.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, jdike@addtoit.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, viro@zeniv.linux.org.uk Subject: Re: [PATCH 1/6] generic sys_old_select References: <20100201185506.GA11045@lst.de> X-Yow: Where's the Coke machine? Tell me a joke!! Date: Mon, 01 Feb 2010 23:40:29 +0100 In-Reply-To: <20100201185506.GA11045@lst.de> (Christoph Hellwig's message of "Mon, 1 Feb 2010 19:55:06 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 984 Lines: 31 Christoph Hellwig writes: > Index: linux-2.6/fs/compat.c > =================================================================== > --- linux-2.6.orig/fs/compat.c 2010-01-12 14:08:16.202003005 +0100 > +++ linux-2.6/fs/compat.c 2010-01-29 23:35:20.187003404 +0100 > @@ -1795,6 +1795,24 @@ asmlinkage long compat_sys_select(int n, > return ret; > } > > +struct compat_sel_arg_struct { > + compat_ulong_t n; > + compat_ulong_t inp; > + compat_ulong_t outp; > + compat_ulong_t exp; > + compat_ulong_t tvp; > +}; Shouldn't the last four be compat_uptr_t? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/