Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755529Ab0BBLF7 (ORCPT ); Tue, 2 Feb 2010 06:05:59 -0500 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:64599 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755185Ab0BBLF4 (ORCPT ); Tue, 2 Feb 2010 06:05:56 -0500 Subject: Re: USB mass storage and ARM cache coherency From: Catalin Marinas To: Paul Mundt Cc: Matthew Dharm , Sergei Shtylyov , Ming Lei , linux-usb@vger.kernel.org, linux-kernel , Sebastian Siewior , Greg KH In-Reply-To: <20100202063904.GK13428@linux-sh.org> References: <20100202063904.GK13428@linux-sh.org> Content-Type: text/plain Organization: ARM Ltd Date: Tue, 02 Feb 2010 11:05:39 +0000 Message-Id: <1265108739.12634.38.camel@pc1117.cambridge.arm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 02 Feb 2010 11:05:40.0235 (UTC) FILETIME=[A7E235B0:01CAA3F7] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 30 On Tue, 2010-02-02 at 06:39 +0000, Paul Mundt wrote: > On Mon, Feb 01, 2010 at 05:29:14PM +0000, Catalin Marinas wrote: > > diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c > > index 27b8f7c..4d3eeee 100644 > > --- a/drivers/usb/host/isp1760-hcd.c > > +++ b/drivers/usb/host/isp1760-hcd.c > > @@ -18,6 +18,8 @@ > > #include > > #include > > #include > > +#include > > +#include > > asm/memory.h isn't a portable header. If you are including it for > virt_to_page(), linux/io.h should already bring that in via asm/io.h. > If arm doesn't bring in virt_to_page() through its asm/io.h, then fix the > headers there please. In the ARM case, yes, it brings virt_to_page() but I'm not sure that's the case for the other architectures. I think a better header is linux/mm.h which already uses this function in virt_to_head_page(). -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/