Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756265Ab0BBOiH (ORCPT ); Tue, 2 Feb 2010 09:38:07 -0500 Received: from ppa02.Princeton.EDU ([128.112.128.216]:40458 "EHLO ppa02.Princeton.EDU" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753613Ab0BBOh7 (ORCPT ); Tue, 2 Feb 2010 09:37:59 -0500 X-Greylist: delayed 555 seconds by postgrey-1.27 at vger.kernel.org; Tue, 02 Feb 2010 09:37:58 EST Date: Tue, 2 Feb 2010 09:28:14 -0500 From: Yury Polyanskiy To: Peter Zijlstra Cc: Herbert Xu , Wei Yongjun , "netdev@vger.kernel.org" , "David S. Miller" , polyanskiy@gmail.com, Thomas Gleixner , lkml Subject: Re: [PATCH] hrtimer, softirq: Fix hrtimer->softirq trampoline Message-ID: <20100202092814.064a89c0@penta.localdomain> In-Reply-To: <1265120401.24455.306.camel@laptop> References: <4B66A670.70503@cn.fujitsu.com> <20100202074914.GD11081@gondor.apana.org.au> <20100202085117.7a5c3530@penta.localdomain> <1265120401.24455.306.camel@laptop> X-Mailer: Claws Mail 3.7.4 (GTK+ 2.18.6; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/V7LzS+8Min1qOl9EyBP8I=H"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1304 Lines: 44 --Sig_/V7LzS+8Min1qOl9EyBP8I=H Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 02 Feb 2010 15:20:01 +0100 Peter Zijlstra wrote: > static enum hrtimer_restart __hrtimer_tasklet_trampoline(struct hrtimer = *timer) > { > struct tasklet_hrtimer *ttimer =3D > container_of(timer, struct tasklet_hrtimer, timer); > =20 > - if (hrtimer_is_hres_active(timer)) { > - tasklet_hi_schedule(&ttimer->tasklet); > - return HRTIMER_NORESTART; > - } > - return ttimer->function(timer); > + tasklet_hi_schedule(&ttimer->tasklet); > + return HRTIMER_NORESTART; > } > =20 Are you totally against if(in_irq())? Yury --Sig_/V7LzS+8Min1qOl9EyBP8I=H Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAktoNn4ACgkQemuRe3zuqOSzZQCfbxHjBimZg9hUOXh1lpEfNAXV y98Anje4TDRX1F5NKK8dm2B8wJ2yi364 =CsGx -----END PGP SIGNATURE----- --Sig_/V7LzS+8Min1qOl9EyBP8I=H-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/