Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756800Ab0BBRW2 (ORCPT ); Tue, 2 Feb 2010 12:22:28 -0500 Received: from mail-bw0-f212.google.com ([209.85.218.212]:49476 "EHLO mail-bw0-f212.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756679Ab0BBRWZ (ORCPT ); Tue, 2 Feb 2010 12:22:25 -0500 X-Greylist: delayed 348 seconds by postgrey-1.27 at vger.kernel.org; Tue, 02 Feb 2010 12:22:24 EST DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=bg9Yq/+QzBZiR2TJ3FAJhWUyi90HJZazB/Y5+/AoYy84R2/tCpYJiXT33w5ABasKgO wr0aKrL7tUndviotQck9++V2W67k2oZV/jwE53GIhM5W+7vJZ/EgNOtFZhPcFK2qC19y jIeThPRiP6hrGuWtdCD9WHbLiM3Cyvm0btpXY= Subject: Re: PROBLEM with summary: Re: [PATCH] netfilter: per netns nf_conntrack_cachep From: Eric Dumazet To: Patrick McHardy Cc: Jon Masters , Alexey Dobriyan , linux-kernel , netdev , netfilter-devel , "Paul E. McKenney" In-Reply-To: <4B685B14.1040207@trash.net> References: <1264813832.2793.446.camel@tonnant> <1264816634.2793.505.camel@tonnant> <1264816777.2793.510.camel@tonnant> <1264834704.2919.3.camel@edumazet-laptop> <1265016745.7499.144.camel@tonnant> <1265019160.2848.14.camel@edumazet-laptop> <1265023437.2848.30.camel@edumazet-laptop> <1265035970.2848.50.camel@edumazet-laptop> <1265036548.2848.55.camel@edumazet-laptop> <1265108690.2861.118.camel@tonnant> <1265110504.2861.135.camel@tonnant> <1265129192.2861.141.camel@tonnant> <1265129903.2861.150.camel@tonnant> <4B685B14.1040207@trash.net> Content-Type: text/plain; charset="UTF-8" Date: Tue, 02 Feb 2010 18:16:30 +0100 Message-ID: <1265130990.2953.176.camel@edumazet-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 923 Lines: 21 Le mardi 02 février 2010 à 18:04 +0100, Patrick McHardy a écrit : > Ah nice catch, that seems to be the problem. When the untracked > conntrack is already attached to an skb and thus has refcnt > 1 > and we re-initalize the refcnt, it will get freed. > > The question is whether the ct_net pointer of the untracked conntrack > is actually required. If so, we need one instance per namespace, > otherwise we can just move initialization and cleanup to the init_net > init/cleanup functions. Alexey, do you happen to know this? > One untracked per netns seems the way to go, and move it outside of read_mostly area too, we obviously can modify its refcount frequently... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/