Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756808Ab0BBRXV (ORCPT ); Tue, 2 Feb 2010 12:23:21 -0500 Received: from dallas.jonmasters.org ([72.29.103.172]:60643 "EHLO dallas.jonmasters.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756679Ab0BBRXU convert rfc822-to-8bit (ORCPT ); Tue, 2 Feb 2010 12:23:20 -0500 Subject: Re: PROBLEM with summary: Re: [PATCH] netfilter: per netns nf_conntrack_cachep From: Jon Masters To: Eric Dumazet Cc: Patrick McHardy , Alexey Dobriyan , linux-kernel , netdev , netfilter-devel , "Paul E. McKenney" In-Reply-To: <1265130990.2953.176.camel@edumazet-laptop> References: <1264813832.2793.446.camel@tonnant> <1264816634.2793.505.camel@tonnant> <1264816777.2793.510.camel@tonnant> <1264834704.2919.3.camel@edumazet-laptop> <1265016745.7499.144.camel@tonnant> <1265019160.2848.14.camel@edumazet-laptop> <1265023437.2848.30.camel@edumazet-laptop> <1265035970.2848.50.camel@edumazet-laptop> <1265036548.2848.55.camel@edumazet-laptop> <1265108690.2861.118.camel@tonnant> <1265110504.2861.135.camel@tonnant> <1265129192.2861.141.camel@tonnant> <1265129903.2861.150.camel@tonnant> <4B685B14.1040207@trash.net> <1265130990.2953.176.camel@edumazet-laptop> Content-Type: text/plain; charset="UTF-8" Organization: World Organi[sz]ation of Broken Dreams Date: Tue, 02 Feb 2010 12:23:01 -0500 Message-Id: <1265131381.2861.164.camel@tonnant> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 8BIT X-SA-Do-Not-Run: Yes X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: jonathan@jonmasters.org X-SA-Exim-Scanned: No (on dallas.jonmasters.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1280 Lines: 30 On Tue, 2010-02-02 at 18:16 +0100, Eric Dumazet wrote: > Le mardi 02 février 2010 à 18:04 +0100, Patrick McHardy a écrit : > > > Ah nice catch, that seems to be the problem. When the untracked > > conntrack is already attached to an skb and thus has refcnt > 1 > > and we re-initalize the refcnt, it will get freed. > > > > The question is whether the ct_net pointer of the untracked conntrack > > is actually required. If so, we need one instance per namespace, > > otherwise we can just move initialization and cleanup to the init_net > > init/cleanup functions. Alexey, do you happen to know this? > > > > One untracked per netns seems the way to go, and move it outside of > read_mostly area too, we obviously can modify its refcount frequently... Sure, that will work. Also, rather than just the NF_CT_ASSERT on the use count, maybe worth catching the specific case of trying to free the untracked ct, but that's only if it's not a horrible fast path. Anyway, thanks. If you want to send me a patch, I'll try it. Jon. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/