Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756802Ab0BBSkF (ORCPT ); Tue, 2 Feb 2010 13:40:05 -0500 Received: from dallas.jonmasters.org ([72.29.103.172]:40300 "EHLO dallas.jonmasters.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756651Ab0BBSkA (ORCPT ); Tue, 2 Feb 2010 13:40:00 -0500 Subject: Re: [PATCH] netfilter: per netns nf_conntrack_cachep From: Jon Masters To: Patrick McHardy Cc: Alexey Dobriyan , Eric Dumazet , linux-kernel , netdev , netfilter-devel , "Paul E. McKenney" In-Reply-To: <4B6870AF.6060109@trash.net> References: <1264813832.2793.446.camel@tonnant> <1265023437.2848.30.camel@edumazet-laptop> <1265035970.2848.50.camel@edumazet-laptop> <1265036548.2848.55.camel@edumazet-laptop> <1265108690.2861.118.camel@tonnant> <1265110504.2861.135.camel@tonnant> <1265129192.2861.141.camel@tonnant> <4B685756.8010107@trash.net> <1265130426.2861.158.camel@tonnant> <1265134598.2861.191.camel@tonnant> <4B6870AF.6060109@trash.net> Content-Type: text/plain Organization: World Organi[sz]ation of Broken Dreams Date: Tue, 02 Feb 2010 13:39:42 -0500 Message-Id: <1265135982.2861.199.camel@tonnant> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-SA-Do-Not-Run: Yes X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: jonathan@jonmasters.org X-SA-Exim-Scanned: No (on dallas.jonmasters.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1159 Lines: 30 On Tue, 2010-02-02 at 19:36 +0100, Patrick McHardy wrote: > Jon Masters wrote: > > On Tue, 2010-02-02 at 19:58 +0200, Alexey Dobriyan wrote: > > > >> Yes, moving to init_net-only function is fine. > > > > So moving the "setup up fake conntrack" bits to init_init_net from > > init_net still results in the panic, which means that the use count > > really is dropping to zero and we really are trying to free it when > > using multiple namespaces. Per ns is probably an easier way to go. > > Agreed, that will also avoid problems in the future with the > ct_net pointer pointing to &init_net. I'll take care of this > tommorrow. Ok. I'll leave this box running with the hack. I think at the very least that this specific issue needs to get fixed and in the stable tree, then the other bits (per namespace cachep...) are probably a good idea at the same time but that's up to you. Thanks for your help! Jon. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/