Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932277Ab0BCBlV (ORCPT ); Tue, 2 Feb 2010 20:41:21 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:38724 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932149Ab0BCBlT (ORCPT ); Tue, 2 Feb 2010 20:41:19 -0500 Date: Tue, 02 Feb 2010 17:41:32 -0800 (PST) Message-Id: <20100202.174132.49841752.davem@davemloft.net> To: ktpedre@sandia.gov Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] seastar - SeaStar Ethernet driver From: David Miller In-Reply-To: <20100202.174045.135005544.davem@davemloft.net> References: <20100202.134251.15604523.davem@davemloft.net> <1265160242.15726.20.camel@hawkeye.sandia.gov> <20100202.174045.135005544.davem@davemloft.net> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 654 Lines: 17 From: David Miller Date: Tue, 02 Feb 2010 17:40:45 -0800 (PST) > From: "Kevin Pedretti" > Date: Tue, 2 Feb 2010 18:24:02 -0700 > >> 2. May want to use alloc_netdev() -> Didn't do this. Would there be a >> substantial advantage to doing this? > > I think you're going to end up having to make this change. Ignore this, using alloc_etherdev() should be just fine. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/