DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=HBcjo65tIasyJiSXw2oXbW/p2pc+x5ttblsgkXoDdgZFB4Q1DFq0g3upMoV71JIRZS
         8IklV9b564KwukQwKPlMjTGQc3vphnGW/CcgvGwTInsCIG3K+6qabE4cwru4iBNDrjqH
         8/iFdJ0FFht7ZkLRbaEWXnIEbMeHut9vQxZoQ=
Date: Tue, 2 Feb 2010 17:53:42 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bob Rodgers <Robert_Rodgers@dell.com>
Cc: Linux-kernel <linux-kernel@vger.kernel.org>,
       Matthew Garrett <mjg59@srcf.ucam.org>, lenb@kernel.org,
       rpurdie@rpsys.net
Subject: Re: Re: [RFC] Dell activity led WMI driver
Message-ID: <20100203015341.GA21173@core.coreip.homeip.net>
References: <4B6898AF.5060703@dell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B6898AF.5060703@dell.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 787
Lines: 25

Hi Bob,

On Tue, Feb 02, 2010 at 03:27:11PM -0600, Bob Rodgers wrote:
> 
> static int __init dell_led_probe(struct platform_device *pdev)
> {

This should either be changed to __devinit or you need to call
platform_device_probe() or, even better, use platform_create_bundle()
that is in next.

But isn't it a bit wasteful to create a brand new platform device only
to attach a single led device to it? I think that, even thourgh LED GUID
is separate, it would be better to keep all this functionality in
dell-wmi driver.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/