Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932346Ab0BCCCG (ORCPT ); Tue, 2 Feb 2010 21:02:06 -0500 Received: from mail.perches.com ([173.55.12.10]:1825 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932270Ab0BCCCF (ORCPT ); Tue, 2 Feb 2010 21:02:05 -0500 Subject: Re: [PATCH] seastar - SeaStar Ethernet driver (review comments addressed) From: Joe Perches To: Kevin Pedretti Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" In-Reply-To: <1265159307.15726.4.camel@hawkeye.sandia.gov> References: <20100202205845.GE5246@hawkeye.sandia.gov> <1265159307.15726.4.camel@hawkeye.sandia.gov> Content-Type: text/plain; charset="UTF-8" Date: Tue, 02 Feb 2010 18:02:01 -0800 Message-ID: <1265162522.1945.148.camel@Joe-Laptop.home> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 32 On Tue, 2010-02-02 at 18:08 -0700, Kevin Pedretti wrote: > diff -uprN -X linux-2.6.32.7-vanilla/Documentation/dontdiff linux-2.6.32.7-vanilla/drivers/net/seastar/main.c linux-2.6.32.7/drivers/net/seastar/main.c > --- linux-2.6.32.7-vanilla/drivers/net/seastar/main.c 1969-12-31 17:00:00.000000000 -0700 > +++ linux-2.6.32.7/drivers/net/seastar/main.c 2010-02-02 17:52:31.000000000 -0700 [] > +static struct pending *alloc_tx_pending(struct ss_priv *ssp) > +{ > + struct pending *pending = ssp->tx_pending_free_list; > + if (!pending) > + return NULL; > + > + ssp->tx_pending_free_list = pending->next; > + pending->next = 0; kernel style doesn't like pointer assignments of 0. NULL is preferred. > + /* Squash broadcast packets, SeaStar doesn't support broadcast */ > + if (dest_lo_mac == 0xFF) { > + dev_err(&ssp->pdev->dev, "squashing broadcast packet."); > + return -1; > + } Presumably SeaStar doesn't support multicast either, so maybe: if (dest_low_mac & 0x01) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/