Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932342Ab0BCCIU (ORCPT ); Tue, 2 Feb 2010 21:08:20 -0500 Received: from mail.vyatta.com ([76.74.103.46]:57314 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932185Ab0BCCIS (ORCPT ); Tue, 2 Feb 2010 21:08:18 -0500 Date: Tue, 2 Feb 2010 18:07:57 -0800 From: Stephen Hemminger To: Joe Perches Cc: Kevin Pedretti , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] seastar - SeaStar Ethernet driver (review comments addressed) Message-ID: <20100202180757.51078dad@nehalam> In-Reply-To: <1265162522.1945.148.camel@Joe-Laptop.home> References: <20100202205845.GE5246@hawkeye.sandia.gov> <1265159307.15726.4.camel@hawkeye.sandia.gov> <1265162522.1945.148.camel@Joe-Laptop.home> Organization: Vyatta X-Mailer: Claws Mail 3.7.2 (GTK+ 2.18.3; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 477 Lines: 14 On Tue, 02 Feb 2010 18:02:01 -0800 Joe Perches wrote: > Presumably SeaStar doesn't support multicast either, so maybe: > if (dest_low_mac & 0x01) Why not: if (is_multicast_ether_addr(ethdr->h_dest)) ... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/