Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757189Ab0BCELQ (ORCPT ); Tue, 2 Feb 2010 23:11:16 -0500 Received: from mail-gx0-f228.google.com ([209.85.217.228]:58604 "EHLO mail-gx0-f228.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753674Ab0BCELP (ORCPT ); Tue, 2 Feb 2010 23:11:15 -0500 Message-ID: <4B68F74B.8000708@billgatliff.com> Date: Tue, 02 Feb 2010 22:10:51 -0600 From: Bill Gatliff User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: H Hartley Sweeten CC: linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PWM PATCH 3/5] Expunge old Atmel PWMC driver, replacing it with one that conforms to the PWM API References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1213 Lines: 37 H Hartley Sweeten wrote: > > You have a couple name changes here, were they intentional? > > Filename: atmel_pwm.c -> atmel-pwm.c > Driver name: atmel_pwm -> atmel_pwmc > Module alias: platform:atmel_pwm -> platform:atmel_pwmc > > Yes. In the datasheet, the peripheral is called the "PWMC" and so that's why the driver name changed. For consistency, I guess I should have named the file atmel-pwmc.c as well. Finally, I find it easier to type file names with dashes rather than underscores. :) > Also, will this new driver still work for all the existing users of > the old one? Are there any platform changes that need to be done? > There are platform changes necessary, to register and use the devices. The driver API is different from the previous code, so there are changes there as well. Functionally, however, the new stuff is a superset of what the previous driver provided. b.g. -- Bill Gatliff bgat@billgatliff.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/