Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932103Ab0BCGaP (ORCPT ); Wed, 3 Feb 2010 01:30:15 -0500 Received: from mail-qy0-f201.google.com ([209.85.221.201]:41442 "EHLO mail-qy0-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756209Ab0BCGaL convert rfc822-to-8bit (ORCPT ); Wed, 3 Feb 2010 01:30:11 -0500 X-Greylist: delayed 376 seconds by postgrey-1.27 at vger.kernel.org; Wed, 03 Feb 2010 01:29:58 EST DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=Z1qFcdhewZxbcnI0PxfpR0kyRqqZt3obLhGYy8fSLc1sfbI4Pmm+wwRzMG05TSJlTf YVkTSC6i6j4Fe08zDkxISayo4AyigcI84kmG6URP9aZ8I14hmYbz5mtRS5zeJXrqMBfm NLsrpDAIQxA+wUyR/FBaUMrFoJxhYPQQ+HQXM= MIME-Version: 1.0 In-Reply-To: References: <0511204199ab83aed2340e70a4639500c0528dab.1265173480.git.amit.kucheria@canonical.com> <9fa7a3c70c46a1f776c6520051481cff6525ef02.1265173480.git.amit.kucheria@canonical.com> From: Eric Miao Date: Tue, 2 Feb 2010 22:29:50 -0800 Message-ID: Subject: Re: [PATCHv2 03/11] mxc: Fix Drive Strength Field in the IOMUX controller To: Amit Kucheria Cc: List Linux Kernel , linux@arm.linux.org.uk, Dinh.Nguyen@freescale.com, s.hauer@pengutronix.de, grant.likely@secretlab.ca, r.herring@freescale.com, linux-arm-kernel@lists.infradead.org, daniel@caiaq.de, bryan.wu@canonical.com, valentin.longchamp@epfl.ch Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2062 Lines: 56 On Tue, Feb 2, 2010 at 9:16 PM, Amit Kucheria wrote: > i.MX51 defines 4 values: > > 00: Low Drive Strength > 01: Medium Drive Strength > 10: High Drive Strength > 11: Max Drive Strength > > Signed-off-by: Amit Kucheria > --- >  arch/arm/plat-mxc/include/mach/iomux-v3.h |    8 +++++--- >  1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/plat-mxc/include/mach/iomux-v3.h b/arch/arm/plat-mxc/include/mach/iomux-v3.h > index 1deda01..f2f73d3 100644 > --- a/arch/arm/plat-mxc/include/mach/iomux-v3.h > +++ b/arch/arm/plat-mxc/include/mach/iomux-v3.h > @@ -81,11 +81,13 @@ struct pad_desc { > >  #define PAD_CTL_ODE                    (1 << 3) > > -#define PAD_CTL_DSE_STANDARD           (0 << 1) > -#define PAD_CTL_DSE_HIGH               (1 << 1) > -#define PAD_CTL_DSE_MAX                        (2 << 1) > +#define PAD_CTL_DSE_LOW                        (0 << 1) > +#define PAD_CTL_DSE_MED                        (1 << 1) > +#define PAD_CTL_DSE_HIGH               (2 << 1) > +#define PAD_CTL_DSE_MAX                        (3 << 1) > I'm seeing some changes in recent kernel with introduction of PAD_CTL_DRV_*, which also affects mx3, think it's a tough problem to keep backward compatibility now, one way out is to introduce maybe PAD_CTL_DRV_EXTREME specifically for imx51. >  #define PAD_CTL_SRE_FAST               (1 << 0) > +#define PAD_CTL_SRE_SLOW               (0 << 0) > >  /* >  * setups a single pad in the iomuxer > -- > 1.6.3.3 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/