Message-ID: <4B6955AE.1090709@pelagicore.com>
Date: Wed, 03 Feb 2010 11:53:34 +0100
From: =?ISO-8859-1?Q?Richard_R=F6jfors?= <richard.rojfors@pelagicore.com>
Organization: Pelagicore AB
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7) Gecko/20100121 Iceowl/1.0b1 Icedove/3.0.1
MIME-Version: 1.0
To: Samuel Ortiz <samuel.ortiz@intel.com>
CC: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] mfd: Add support for the timberdale FPGA.
References: <4B694463.6050306@pelagicore.com> <20100203104448.GB3460@sortiz.org>
In-Reply-To: <20100203104448.GB3460@sortiz.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1019
Lines: 29

On 02/03/2010 11:45 AM, Samuel Ortiz wrote:
> Hi Richard,
>
> On Wed, Feb 03, 2010 at 09:39:47AM +0000, Richard R?jfors wrote:
>> The timberdale FPGA is found on the Intel in-Vehicle Infotainment reference board
>> russelville.
>>
>> The driver is a PCI driver which chunks up the I/O memory and distributes interrupts
>> to a number of platform devices for each IP inside the FPGA.
>>
>> Signed-off-by: Richard R?jfors<richard.rojfors@pelagicore.com>
> The patch looks good to me, I have a couple of minor comments though:
>
> - Please replace most of your printk with dev_dbg/err()

Agreed.

> - Please fix your checkpatch output:
> total: 255 errors, 18 warnings, 822 lines checked

Sweet, the mail client changed all tabs to spaces when resending the patch.

--Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/