Date: Wed, 3 Feb 2010 16:23:22 +0100
From: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
To: albert_herranz@yahoo.es
Cc: siccegge@stud.informatik.uni-erlangen.de,
       vamos@i4.informatik.uni-erlangen.de, linux-kernel@vger.kernel.org,
       mb@bu3sch.de
Subject: Unreachable block in Kernel Code (CONFIG_SSB_SDIO)
Message-ID: <20100203152322.GA7167@faui49.informatik.uni-erlangen.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1577
Lines: 45

Hi all!

	As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig
options and in-code Conditional blocks.

	In git commit 24ea602e183ca20a7577ebe253323d0e5d0f9847 you
introduced SDIO in drivers/ssb/main.c. While most of the config checks
look for CONFIG_SSB_SDIOHOST there's one check for CONFIG_SSB_SDIO
which looks wrong (and is one of the CONFIG_ vars that are not defined
anywhere in source neither avaiable in kconfig.

	Changing this only occurence to SDIOHOST [0] as well however
unfortunately results in a build failure [1] I can't find the correct
way to fix. Maybe you know how to correctly handle that?

	Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.

Regards

	Christoph Egger

[0]
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -494,7 +494,7 @@ static int ssb_devices_register(struct ssb_bus
*bus)
 #endif
                        break;
                case SSB_BUSTYPE_SDIO:
-#ifdef CONFIG_SSB_SDIO
+#ifdef CONFIG_SSB_SDIOHOST
                        sdev->irq = bus->host_sdio->dev.irq;
                        dev->parent = &bus->host_sdio->dev;
 #endif

[1]
drivers/ssb/main.c: In function 'ssb_devices_register':
drivers/ssb/main.c:498: error: 'struct device' has no member named 'irq'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/