From: Oliver Neukum <oliver@neukum.org>
To: roel kluin <roel.kluin@gmail.com>
Subject: Re: [PATCH] dvb: return -ENOMEM if kzalloc failed in dvb_usb_device_init()
Date: Wed, 3 Feb 2010 17:16:03 +0100
User-Agent: KMail/1.12.2 (Linux/2.6.33-rc6-0.1-default; KDE/4.3.1; x86_64; ; )
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>, linux-media@vger.kernel.org,
       Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
References: <4B6836DA.8030907@gmail.com> <201002021529.36727.oliver@neukum.org> <25e057c01002030802x5ae68ed9od9004565731ebd6f@mail.gmail.com>
In-Reply-To: <25e057c01002030802x5ae68ed9od9004565731ebd6f@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201002031716.03782.oliver@neukum.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 915
Lines: 25

Am Mittwoch, 3. Februar 2010 17:02:49 schrieb roel kluin:
> > The bug is caused by this:
> >
> >        if (cold) {
> >                info("found a '%s' in cold state, will try to load a firmware",desc->name);
> >                ret = dvb_usb_download_firmware(udev,props);
> >                if (!props->no_reconnect || ret != 0)
> >                        return ret;
> >        }
> >
> > which overwrites ret
> 
> Is that an ack or do you want me to add an int (e.g. rc) that
> handles the dvb_usb_download_firmware() return value?

This is an ack with an additional comment that this function is in need of
a cleanup due to unnecessary subtlety.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/