Subject: Re: [PATCH 3/3] kernel-shark: fix unitialized handle compile
 warnings
From: Steven Rostedt <rostedt@goodmis.org>
Reply-To: rostedt@goodmis.org
To: John Kacur <jkacur@redhat.com>
Cc: Darren Hart <dvhltc@us.ibm.com>, linux-kernel@vger.kernel.org
In-Reply-To: <1265213851.24386.1.camel@gandalf.stny.rr.com>
References: <1265043026-24987-1-git-send-email-dvhltc@us.ibm.com>
	 <1265043026-24987-4-git-send-email-dvhltc@us.ibm.com>
	 <520f0cf11002030805q35029925u36f544f7d37faedb@mail.gmail.com>
	 <1265213851.24386.1.camel@gandalf.stny.rr.com>
Content-Type: text/plain; charset="ISO-8859-15"
Organization: Kihon Technologies Inc.
Date: Wed, 03 Feb 2010 11:19:05 -0500
Message-ID: <1265213945.24386.2.camel@gandalf.stny.rr.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 972
Lines: 36

On Wed, 2010-02-03 at 11:17 -0500, Steven Rostedt wrote:
> andle)
> > > -               handle = tracecmd_open(input_file);
> > > +       handle = tracecmd_open(input_file);
> > >
> > > -       info->handle = handle;
> > > +       if (handle)
> > > +               info->handle = handle;
> > >
> > >        /* --- Main window --- */
> > >
> > > --
> > 
> > This looks correct, but I'm wondering if it is safe to continue if the
> > call to tracecmd_open fails?
> 
> Actually this patch is wrong. The real code should be:
> 
> -	if (handle)
> +	if (input_file)

Looking at the context, this isn't enough. We should have had:

	if (input_file)
		info->handle = tracecmd_open(input_file);
	else
		info->handle = NULL;

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/