Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932581Ab0BCQqs (ORCPT ); Wed, 3 Feb 2010 11:46:48 -0500 Received: from mail-gx0-f224.google.com ([209.85.217.224]:64525 "EHLO mail-gx0-f224.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932512Ab0BCQqp (ORCPT ); Wed, 3 Feb 2010 11:46:45 -0500 MIME-Version: 1.0 In-Reply-To: References: <0511204199ab83aed2340e70a4639500c0528dab.1265173480.git.amit.kucheria@canonical.com> <9fa7a3c70c46a1f776c6520051481cff6525ef02.1265173480.git.amit.kucheria@canonical.com> <240f12ca87d7666f31263aabc620a9ec197cd8ff.1265173480.git.amit.kucheria@canonical.com> <752ae69adb57d4f73fa011ba380cea1b927b9c8b.1265173480.git.amit.kucheria@canonical.com> From: Grant Likely Date: Wed, 3 Feb 2010 09:46:24 -0700 X-Google-Sender-Auth: d788f5c8987d6291 Message-ID: Subject: Re: [PATCHv2 08/11] fec: fix uninitialized rx buffer usage To: Amit Kucheria Cc: List Linux Kernel , Rob Herring , "David S. Miller" , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, s.hauer@pengutronix.de, valentin.longchamp@epfl.ch, daniel@caiaq.de, Dinh.Nguyen@freescale.com, bryan.wu@canonical.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 24 On Tue, Feb 2, 2010 at 10:16 PM, Amit Kucheria wrote: > From: Rob Herring > > The fec driver was enabling receive buffer descriptor without allocating > the buffers. Make sure the buffer descriptors are initialized to not > start receiving packets. > > Open also calls fec_restart after the rx buffers are allocated. With the code > in fec_restart, it zeroes out the buffer descriptors that have just been > setup. fec related patches 8 & 9 look okay to me. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/